Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 188693004: Revert of Enable the volume slider in Ash for windows. (Closed)

Created:
6 years, 9 months ago by pkotwicz
Modified:
6 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Revert of Enable the volume slider in Ash for windows. (https://codereview.chromium.org/178883004/) Reason for revert: Experimentally reverting this CL because it may have broken AshTestHelperTest.AshTestHelper on Windows Vista . Will revert the revert if this CL is innocent See http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%282%29/builds/41640/steps/ash_unittests/logs/AshTestHelper Original issue's description: > Enable the volume slider in Ash for windows. > > BUG=227247 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255215 TBR=henrika@chromium.org,tommi@chromium.org,jennyz@chromium.org,dewittj@chromium.org,zturner@chromium.org NOTREECHECKS=true NOTRY=true BUG=227247 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -237 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/system/audio/tray_audio_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D ash/system/win/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ash/system/win/audio/tray_audio_delegate_win.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ash/system/win/audio/tray_audio_delegate_win.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D ash/system/win/audio/tray_audio_win.h View 1 chunk +0 lines, -28 lines 0 comments Download
D ash/system/win/audio/tray_audio_win.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M media/audio/win/core_audio_util_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pkotwicz
Created Revert of Enable the volume slider in Ash for windows.
6 years, 9 months ago (2014-03-06 16:13:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/188693004/1
6 years, 9 months ago (2014-03-06 16:14:27 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 16:15:57 UTC) #3
Message was sent while issue was closed.
Change committed as 255363

Powered by Google App Engine
This is Rietveld 408576698