Fix uncaught exception on ios_dbg_simulator_ninja bots.

Fix uncaught exception on ios_dbg_simulator_ninja bots.

R=martiniss@chromium.org, smut@chromium.org
BUG=603641
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299945

[martiniss, 2016-04-15 00:56:21]

lgtm

[Dirk Pranke, 2016-04-15 00:56:38]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-04-15 00:56:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886813005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886813005/1

[commit-bot: I haz the power, 2016-04-15 01:00:25]

Description was changed from

==========
Fix uncaught exception on ios_dbg_simulator_ninja bots.

R=martiniss@chromium.org, smut@chromium.org
BUG=603641
==========

to

==========
Fix uncaught exception on ios_dbg_simulator_ninja bots.

R=martiniss@chromium.org, smut@chromium.org
BUG=603641

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299945
==========

[commit-bot: I haz the power, 2016-04-15 01:00:25]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299945

[smut, 2016-04-15 01:43:11]

smut@google.com changed reviewers:
+ smut@google.com

[smut, 2016-04-15 01:43:12]

https://codereview.chromium.org/1886813005/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/ios/api.py (right):

https://codereview.chromium.org/1886813005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/ios/api.py:344:
self.m.chromium.apply_config('goma')
Could apply these in read_build_config.

[Dirk Pranke, 2016-04-15 01:46:20]

https://codereview.chromium.org/1886813005/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/ios/api.py (right):

https://codereview.chromium.org/1886813005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/ios/api.py:344:
self.m.chromium.apply_config('goma')
On 2016/04/15 01:43:12, smut wrote:
> Could apply these in read_build_config.

I thought about that but I would have to make sure the self.compiler,
gyp_defines,
and gn_args were set correctly at that point, and it looked like that was not a
4-line change, 
which is why I made this change instead and left in the TODO.

Next chance I get to get some breathing room, I'll come back and clean this up.

[smut, 2016-04-15 02:04:16]

On 2016/04/15 01:46:20, Dirk Pranke wrote:
>
https://codereview.chromium.org/1886813005/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/ios/api.py (right):
> 
>
https://codereview.chromium.org/1886813005/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/ios/api.py:344:
> self.m.chromium.apply_config('goma')
> On 2016/04/15 01:43:12, smut wrote:
> > Could apply these in read_build_config.
> 
> I thought about that but I would have to make sure the self.compiler,
> gyp_defines,
> and gn_args were set correctly at that point, and it looked like that was not
a
> 4-line change, 
> which is why I made this change instead and left in the TODO.
> 
> Next chance I get to get some breathing room, I'll come back and clean this
up.

sgtm/lgtm