Fix uncaught exception on ios_dbg_simulator_ninja bots.

scripts/slave/recipe_modules/ios/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 
 from recipe_engine import recipe_api
 
 
 class iOSApi(recipe_api.RecipeApi):
@@ skipping 315 matching lines @@
           test['skip'] = True
 
       if compile_targets: # pragma: no cover
         cmd.extend(compile_targets)
       else:
         return
 
     use_goma = (self.compiler == 'ninja' and
                 ('use_goma=1' in gyp_defines or 'use_goma=true' in gn_args))
     if use_goma:
-      self.m.chromium.apply_config('ninja')
-      self.m.chromium.apply_config('default_compiler')
-      self.m.chromium.apply_config('goma')
+      if 'without patch' not in suffix:
+        # TODO(crbug.com/603641):
+        # Configs aren't deapplied, so we only want to apply these
+        # configs once. Really, we should refactor this so that we're
+        # not applying configs at all in build(), but rather do it
+        # in an earlier step.
+        self.m.chromium.apply_config('ninja')
+        self.m.chromium.apply_config('default_compiler')
+        self.m.chromium.apply_config('goma')

[smut, 2016/04/15 01:43:12]

Could apply these in read_build_config.

[Dirk Pranke, 2016/04/15 01:46:20]

I thought about that but I would have to make sure the self.compiler,
gyp_defines,
and gn_args were set correctly at that point, and it looked like that was not a
4-line change, 
which is why I made this change instead and left in the TODO.

Next chance I get to get some breathing room, I'll come back and clean this up.

       self.m.chromium.compile(targets=compile_targets,
                               target=build_sub_path,
                               cwd=cwd)
     else:
       self.m.step('compile' + suffix, cmd, cwd=cwd)
 
   def test(self, *args):
     """Runs tests as instructed by this bot's build config.
 
     Args:
@@ skipping 132 matching lines @@
         self.configuration,
         'iossim',
       ),
       'ninja': self.m.path.join(
         'src',
          build_dir,
          '%s-%s' % (self.configuration, platform),
          'iossim',
       ),
     }[self.compiler]