Issue 1886763003: parent->addChild() can delete parent and any of its siblings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1886763003: parent->addChild() can delete parent and any of its siblings (Closed)

Created:
4 years, 8 months ago by robhogan (do not use)

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

More Reviews

Description

parent->addChild() can delete parent and any of its siblings Once you call parent->addChild() your pointers to parent and any floating or out-of-flow siblings it has are no longer safe. BUG=602271 Review URL: https://codereview.chromium.org/1879553003 Cr-Commit-Position: refs/heads/master@{#386827} (cherry picked from commit 741853f64fe49635e5b02b641b3799bdeacec37f) Committed: https://chromium.googlesource.com/chromium/src/+/bdaff5b6a0ca169b95cedd9d3ba0b4e5f971ff4a

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -5 lines)			Patch
M	third_party/WebKit/LayoutTests/TestExpectations	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/lists/remove-listmarker-and-make-anonblock-empty-2.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A +	third_party/WebKit/LayoutTests/fast/lists/remove-listmarker-and-make-anonblock-empty-2-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/create-list-with-hr-expected.png	View	Binary file		0 comments	Download
M	third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/create-list-with-hr-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutListItem.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

robhogan (do not use)

4 years, 8 months ago (2016-04-13 18:35:45 UTC) #1

Description was changed from

==========
parent->addChild() can delete parent and any of its siblings

Once you call parent->addChild() your pointers to parent and any floating or
out-of-flow siblings it has are no longer safe.

BUG=602271

Review URL: https://codereview.chromium.org/1879553003

Cr-Commit-Position: refs/heads/master@{#386827}
(cherry picked from commit 741853f64fe49635e5b02b641b3799bdeacec37f)
==========

to

==========
parent->addChild() can delete parent and any of its siblings

Once you call parent->addChild() your pointers to parent and any floating or
out-of-flow siblings it has are no longer safe.

BUG=602271

Review URL: https://codereview.chromium.org/1879553003

Cr-Commit-Position: refs/heads/master@{#386827}
(cherry picked from commit 741853f64fe49635e5b02b641b3799bdeacec37f)

Committed:
https://chromium.googlesource.com/chromium/src/+/bdaff5b6a0ca169b95cedd9d3ba0...
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages