Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1879553003: parent->addChild() can delete parent and any of its siblings (Closed)

Created:
4 years, 8 months ago by rhogan
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@396717-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

parent->addChild() can delete parent and any of its siblings Once you call parent->addChild() your pointers to parent and any floating or out-of-flow siblings it has are no longer safe. BUG=602271 Committed: https://crrev.com/741853f64fe49635e5b02b641b3799bdeacec37f Cr-Commit-Position: refs/heads/master@{#386827}

Patch Set 1 #

Patch Set 2 : Updated #

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
lgtm, but the bug you're referring to doesn't exist. Please fix that before landing.
4 years, 8 months ago (2016-04-12 19:36:19 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1868013002 Patch 40001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-12 20:00:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879553003/20001
4 years, 8 months ago (2016-04-12 20:54:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 22:06:31 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 22:08:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/741853f64fe49635e5b02b641b3799bdeacec37f
Cr-Commit-Position: refs/heads/master@{#386827}

Powered by Google App Engine
This is Rietveld 408576698