Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1886763002: Fix crash when AppBannerClient is null when resolveBeforeInstallPromptPromise is called. (Closed)

Created:
4 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when AppBannerClient is null when resolveBeforeInstallPromptPromise is called. The crash is a regression from: https://codereview.chromium.org/1807643002 There is now a simple layout test preventing a similar regression. BUG=601480 R=jochen@chromium.org Committed: https://crrev.com/005172539b5aefaa52273ebe784f14e2bb16d15a Cr-Commit-Position: refs/heads/master@{#387326}

Patch Set 1 #

Patch Set 2 : no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M components/test_runner/test_runner.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mlamouri (slow - plz ping)
4 years, 8 months ago (2016-04-13 13:33:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886763002/20001
4 years, 8 months ago (2016-04-13 13:33:34 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 14:42:26 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-14 13:40:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886763002/20001
4 years, 8 months ago (2016-04-14 13:40:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 15:50:53 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 15:52:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/005172539b5aefaa52273ebe784f14e2bb16d15a
Cr-Commit-Position: refs/heads/master@{#387326}

Powered by Google App Engine
This is Rietveld 408576698