Issue 188673003: CHROME_HEADLESS is always Pro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 188673003: CHROME_HEADLESS is always Pro (Closed)

Created:
6 years, 9 months ago by scottmg

Modified:
6 years, 9 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

CHROME_HEADLESS is always Pro Follow up to https://codereview.chromium.org/185423004/ The unzip is always Pro, and without setting this the data.json will be getting the Express settings and so gyp will generate the wrong project. TBR=iannucci@chromium.org BUG=323300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255378

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	win_toolchain/toolchain2013.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

scottmg

6 years, 9 months ago (2014-03-06 17:08:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r255378 (presubmit successful).