Issue 185423004: Add toolchain simple mirror option used for bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185423004: Add toolchain simple mirror option used for bots (Closed)

Created:
6 years, 9 months ago by scottmg

Modified:
6 years, 9 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Add toolchain simple mirror option used for bots I tried a git-ish tree/blob model, but way too slow for a ton of files. This maps easily on to the current way the tree is mapped, saves temp space on bots (because the full isos aren't downloaded), and is a lot faster too. It means we can pull old revisions too now. TBR=iannucci@chromium.org BUG=348350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254421

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : abspath for target #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -15 lines)			Patch
	M	win_toolchain/get_toolchain_if_necessary.py	View		4 chunks	+6 lines, -4 lines	0 comments	Download
	M	win_toolchain/toolchain2013.py	View	1 2	5 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottmg

tbr'ing to try to fix tryserver bots (see bug). I'll do a followup after review ...

6 years, 9 months ago (2014-03-02 22:58:43 UTC) #1

scottmg

6 years, 9 months ago (2014-03-02 23:00:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r254421 (presubmit successful).

Expand Messages | Collapse Messages