Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1886723002: [heap] Sweeper refactoring round 2 (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Sweeper refactoring round 2 - Get rid of temp lists and use a lock-protected deque instead BUG= Committed: https://crrev.com/98401b843eea49293522dc9c6640b1d9baf66b85 Cr-Commit-Position: refs/heads/master@{#35448}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -59 lines) Patch
M src/heap/mark-compact.h View 4 chunks +9 lines, -14 lines 0 comments Download
M src/heap/mark-compact.cc View 6 chunks +33 lines, -45 lines 0 comments Download

Dependent Patchsets:

Issue 1881423003 Patch 110001

Messages

Total messages: 13 (6 generated)
Michael Lippautz
ptal - this incorporates your suggestion of only having a concurrent list (deque) where we ...
4 years, 8 months ago (2016-04-13 12:25:04 UTC) #3
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-13 13:21:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886723002/20001
4 years, 8 months ago (2016-04-13 13:22:43 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 13:51:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886723002/20001
4 years, 8 months ago (2016-04-13 13:52:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-13 13:54:40 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 13:55:25 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/98401b843eea49293522dc9c6640b1d9baf66b85
Cr-Commit-Position: refs/heads/master@{#35448}

Powered by Google App Engine
This is Rietveld 408576698