Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1881423003:
[heap] Better integrate handling of aborted compaction pages (Closed)
|
Created:
4 years, 8 months ago by Michael Lippautz Modified:
4 years, 8 months ago Reviewers:
Hannes Payer (out of office) CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Better integrate handling of aborted compaction pages
- Get rid of fixing up pointers on the main thread
- Get rid of sweeping on the main thread
Instead:
- Record (and process afterwards) slots in parallel
- Add the pages to the concurrent sweeper as pointers have already been fixed
BUG=chromium:581412
LOG=N
TEST=cctest/test-compaction/*
Committed: https://crrev.com/2e4f57774d4993f9f98332d3b2469280ee10beca
Cr-Commit-Position: refs/heads/master@{#35451}
Patch Set 1 #Patch Set 2 : Get rid of COMPACTION_WAS_ABORTED flag (dead code) #Patch Set 3 : Remove outdated DCHECK #Patch Set 4 : Fix handling of aborted pages wrt. DCHECKs #Patch Set 5 : Bring back COMPACTION_WAS_ABORTED to have better DCHECK coverage #Patch Set 6 : Rebase on sweeper round 2 refactoring #Patch Set 7 : Rebase on master #
Messages
Total messages: 34 (18 generated)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423003/1
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423003/10004 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423003/10004
Description was changed from ========== [heap] Better integrate handling of aborted compaction pages - Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* ========== to ========== [heap] Better integrate handling of aborted compaction pages - Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* ==========
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/5733) v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423003/50001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/4158) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423003/70001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423003/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423003/90001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/4186) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
Patchset #5 (id:70001) has been deleted
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423003/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423003/130001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/1881423003/#ps130001 (title: "Rebase on master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423003/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423003/130001
Message was sent while issue was closed.
Description was changed from ========== [heap] Better integrate handling of aborted compaction pages - Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* ========== to ========== [heap] Better integrate handling of aborted compaction pages - Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* ==========
Message was sent while issue was closed.
Committed patchset #7 (id:130001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Better integrate handling of aborted compaction pages - Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* ========== to ========== [heap] Better integrate handling of aborted compaction pages - Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* Committed: https://crrev.com/2e4f57774d4993f9f98332d3b2469280ee10beca Cr-Commit-Position: refs/heads/master@{#35451} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/2e4f57774d4993f9f98332d3b2469280ee10beca Cr-Commit-Position: refs/heads/master@{#35451}
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:130001) has been created in https://codereview.chromium.org/1890553002/ by mlippautz@chromium.org. The reason for reverting is: Breaks: https://uberchromegw.corp.google.com/i/client.v8.ports/builders/V8%20Linux%20... RecordMigratedSlotVisitor is not safe to use on code pages.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
