Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 188663003: Revert 255262 "Migrate chrome.bluetooth API backend to use devic..." (Closed)

Created:
6 years, 9 months ago by earthdok
Modified:
6 years, 9 months ago
Reviewers:
armansito
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255262 "Migrate chrome.bluetooth API backend to use devic..." Reverted due to memory leaks. > Migrate chrome.bluetooth API backend to use device::BluetoothDiscoverySession. > > Modified chrome.bluetooth API code to use the new discovery session API for > device discovery. > > BUG=346982 > TEST=1. unit_tests, browser_tests > 2. Use multiple running extension instances with the bluetooth permission and check for the following behavior: > - Only one session per extension. Calling chrome.bluetooth.stopDiscovery from one running app should fail if that app never called chrome.bluetooth.startDiscovery. > - An app's discovery sessions should get cleaned up if that app crashes or unloads. > - Use bt_console and run "power off". This should cause all discovery sessions that have been assigned to apps to get marked as inactive. Verify by requesting a new discovery session from apps, which should succeed. > > Review URL: https://codereview.chromium.org/179123008 TBR=armansito@chromium.org BUG=349942 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -269 lines) Patch
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 2 chunks +19 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 9 chunks +30 lines, -59 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h View 5 chunks +15 lines, -30 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 8 chunks +33 lines, -85 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/api_test/bluetooth/discovery_in_progress/runtest.js View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth_discovery_session.h View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_discovery_session.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M trunk/src/device/bluetooth/test/mock_bluetooth_adapter.h View 2 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/device/bluetooth/test/mock_bluetooth_adapter.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/src/device/bluetooth/test/mock_bluetooth_discovery_session.h View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/device/bluetooth/test/mock_bluetooth_discovery_session.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
earthdok
6 years, 9 months ago (2014-03-06 16:50:03 UTC) #1
earthdok
6 years, 9 months ago (2014-03-06 16:50:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255372.

Powered by Google App Engine
This is Rietveld 408576698