Migrate chrome.bluetooth API backend to use device::BluetoothDiscoverySession.

Migrate chrome.bluetooth API backend to use device::BluetoothDiscoverySession.

Modified chrome.bluetooth API code to use the new discovery session API for
device discovery.

BUG=346982
TEST=1. unit_tests, browser_tests
     2. Use multiple running extension instances with the bluetooth permission and check for the following behavior:
        - Only one session per extension. Calling chrome.bluetooth.stopDiscovery from one running app should fail if that app never called chrome.bluetooth.startDiscovery.
        - An app's discovery sessions should get cleaned up if that app crashes or unloads.
        - Use bt_console and run "power off". This should cause all discovery sessions that have been assigned to apps to get marked as inactive. Verify by requesting a new discovery session from apps, which should succeed.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255262

[armansito, 2014-03-01 00:58:07]

This CL depends on https://codereview.chromium.org/184953002/. I will add some
unit tests to bluetooth_event_router_unittest.cc later.

[keybuk, 2014-03-04 00:52:07]

lgtm though consider the naming issue a strong nit ;-)

https://codereview.chromium.org/179123008/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h (right):

https://codereview.chromium.org/179123008/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h:102: const
base::Closure& error_callback);
nit: you have AddDiscoverySession that calls StartDiscoverySession that calls
AddDiscoverySession

and RemoveDiscoverySession that call session->Stop that calls
RemoveDiscoverySession

Either the first should be Start/Stop or the middle should not be ;-)

[armansito, 2014-03-04 01:16:55]

https://codereview.chromium.org/179123008/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h (right):

https://codereview.chromium.org/179123008/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h:102: const
base::Closure& error_callback);
On 2014/03/04 00:52:07, keybuk wrote:
> nit: you have AddDiscoverySession that calls StartDiscoverySession that calls
> AddDiscoverySession
> 
> and RemoveDiscoverySession that call session->Stop that calls
> RemoveDiscoverySession
> 
> Either the first should be Start/Stop or the middle should not be ;-)

Done.

[armansito, 2014-03-05 07:11:33]

Ok, it seems like the linux_chromeos and linux_chromeos_clang bots have gone
past the compile stage for patch set 5, so the compile error that we were seeing
was clearly an issue with the trybots and not the code itself. The fact that the
error stated that the superclass constructor was declared "private" was in
itself wrong anyway, so clearly it wasn't compiling the correct piece of code.

That being said, I made some minor changes to the code that I think is cleaner
from a style point of view. I added a no-argument constructor to
BluetoothDiscoverySession that sets |active_| to false. The constructor is
defined as protected and it's only meant to be called from the constructor of
MockBluetoothDiscoverySession, which is now also a simple, no-argument
constructor. I think it didn't make sense for the MockBluetoothDiscoverySession
constructor to take in the adapter as an argument as it's just a mock.

As a summary, the things I learned (or rather "asserted") today about
constructors in C++:

  1. It is completely legal for a public constructor to invoke a protected
superclass constructor in its initializer list.
  2. C++ automatically calls the no-argument constructor of all superclasses of
a class, regardless of the number of arguments in the constructor of said class.
  3. If a subclass constructor doesn't explicitly invoke a valid constructor of
its superclass and the superclass doesn't define a no-argument constructor AND
no default constructor is synthesized for the superclass by the compiler, the
code won't compile, regardless of the number of arguments in the constructor of
the subclass.
  4. Mocks suck.

[armansito, 2014-03-05 08:04:01]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-03-05 08:05:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/179123008/100001

[commit-bot: I haz the power, 2014-03-05 09:35:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 09:35:34]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[armansito, 2014-03-05 10:06:35]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-03-05 10:06:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/179123008/100001

[commit-bot: I haz the power, 2014-03-05 12:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 12:16:01]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[armansito, 2014-03-05 16:46:18]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-03-05 16:48:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/179123008/100001

[commit-bot: I haz the power, 2014-03-05 23:55:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/179123008/100001

[commit-bot: I haz the power, 2014-03-06 02:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 02:21:57]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[armansito, 2014-03-06 02:22:50]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-03-06 02:24:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/179123008/100001

[commit-bot: I haz the power, 2014-03-06 03:09:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/179123008/100001

[commit-bot: I haz the power, 2014-03-06 05:40:21]

Change committed as 255262