Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1886603002: DevTools: remove InspectorTests.runAfterPendingDispatches call from audits tests (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pending-dispatches
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove InspectorTests.runAfterPendingDispatches call from audits tests R=dgozman, pfeldman_ooo BUG=602843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/inspector/audits/audits-empty-stylesheet.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/audits/audits-panel-functional.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/audits/audits-panel-noimages-functional.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/audits/audits-test.js View 2 chunks +3 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1877223003 Patch 20001

Messages

Total messages: 7 (2 generated)
lushnikov
ptal
4 years, 8 months ago (2016-04-13 00:25:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886603002/1
4 years, 8 months ago (2016-04-13 00:25:54 UTC) #3
dgozman
Well, if it works... lgtm
4 years, 8 months ago (2016-04-13 00:33:40 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/52740)
4 years, 8 months ago (2016-04-13 01:39:23 UTC) #6
lushnikov
4 years, 8 months ago (2016-04-13 23:52:20 UTC) #7 
For the record:

This doesn't work due to inspector/extensions/extensions-audits.html test. The
audit extensions can add complex objects to audit results, e.g. DOMNodes and
RemoteObjects.

We probably need a general "expand tree" method, which accounts for lazy loading
of the tree.

For now, closing this.

Powered by Google App Engine
This is Rietveld 408576698