Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1877223003: DevTools: deprecate InspectorTest.runAfterPendingDispatches (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: deprecate InspectorTest.runAfterPendingDispatches The InspectorTest.runAfterPendingDispatches results in an eventual test flakiness, increasing maintanence burden. Clients should consider other ways instead of using InspectorTest.runAfterPendingDispatches, e.g. adding a specific _methodForTest method which will be sniffed. R=dgozman BUG=602843 Committed: https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d Cr-Commit-Position: refs/heads/master@{#387101}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -96 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/database-open.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/dom-storage-open.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/dynamic-scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-fetch-logging.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging-async.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/fragment.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/load-resource-for-frontend.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-blocked-reason.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-reload.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-manager.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/audits/audits-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-big-array.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-clear.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-scoped.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-array-prototype.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-broken-unicode.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-last-result.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-wrapped-in-framework.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-tainted-globals.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-1.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-3.html View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-4.html View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-shadow-2.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-test.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/insert-node-collapsed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-inspect-iframe-from-different-domain.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-limited-children.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-selection-on-refresh.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/expand-recursively.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/metrics-box-sizing.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/updates-during-dom-traversal.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/updates-throttled.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-audits-api.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-resources.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/load-file-resource-for-frontend.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-after-suspension.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-xhr.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-change-variable.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/skip-pauses-until-reload.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-inline-values.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/dynamic-scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/storage-panel-dom-storage.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js View 1 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
lushnikov
please, take a look. This is to avoid the temptation of using the method in ...
4 years, 8 months ago (2016-04-13 00:05:44 UTC) #1
pfeldman
On 2016/04/13 00:05:44, lushnikov wrote: > please, take a look. > > This is to ...
4 years, 8 months ago (2016-04-13 00:10:51 UTC) #2
lushnikov
I have a history of flakiness produced by this method. The latest example is here: ...
4 years, 8 months ago (2016-04-13 00:19:01 UTC) #4
dgozman
lgtm, but we have to work on removing it gradually.
4 years, 8 months ago (2016-04-13 19:39:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877223003/20001
4 years, 8 months ago (2016-04-13 19:39:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/50355)
4 years, 8 months ago (2016-04-13 19:53:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877223003/20001
4 years, 8 months ago (2016-04-13 21:08:06 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 21:28:56 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 21:30:01 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d
Cr-Commit-Position: refs/heads/master@{#387101}

Powered by Google App Engine
This is Rietveld 408576698