Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1886573006: [api] Deprecate *MemoryAllocationCallback (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Deprecate *MemoryAllocationCallback To keep track of memory characteristics of a JS program use GetHeapSpaceStatistics from a combination of - a GC epilogue callback registered using AddGCEpilogueCallback - an interrupt registered using RequestInterrupt Rationale: The feature is currently broken as those callbacks are (also) executed from background threads, breaking our implicit contract for only performing callbacks on the foreground thread. Furhtermore, it's not clear for the embedder whether these allocations originate in JS, or are required for a GC. Note: - The already deprecated non-isolate versions are removed with this CL. R=jochen@chromium.org BUG=v8:4813 LOG=Y Committed: https://crrev.com/97e3909a53a1865df1032d31c3870395c210579a Cr-Commit-Position: refs/heads/master@{#35474}

Patch Set 1 #

Patch Set 2 : Remove already deprecated non-isolate versions of the API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M include/v8.h View 1 3 chunks +7 lines, -35 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Michael Lippautz
Jochen: ptal Hannes: fyi
4 years, 8 months ago (2016-04-14 07:35:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-14 07:41:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886573006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886573006/1
4 years, 8 months ago (2016-04-14 07:44:39 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/14681)
4 years, 8 months ago (2016-04-14 07:53:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886573006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886573006/20001
4 years, 8 months ago (2016-04-14 08:03:45 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 08:27:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886573006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886573006/20001
4 years, 8 months ago (2016-04-14 08:51:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 08:53:35 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 08:53:48 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97e3909a53a1865df1032d31c3870395c210579a
Cr-Commit-Position: refs/heads/master@{#35474}

Powered by Google App Engine
This is Rietveld 408576698