Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2053)

Unified Diff: include/v8.h

Issue 1886573006: [api] Deprecate *MemoryAllocationCallback (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove already deprecated non-isolate versions of the API Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 7952fc9bd1e1b9b9cb5d85c920dee149582ff4ad..bc6edf5cea8ab4bb2d64e7716c8a8ddbb0fcd133 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -6225,13 +6225,17 @@ class V8_EXPORT Isolate {
* Enables the host application to provide a mechanism to be notified
* and perform custom logging when V8 Allocates Executable Memory.
*/
- void AddMemoryAllocationCallback(MemoryAllocationCallback callback,
- ObjectSpace space, AllocationAction action);
+ void V8_DEPRECATED(
+ "Use a combination of RequestInterrupt and GCCallback instead",
+ AddMemoryAllocationCallback(MemoryAllocationCallback callback,
+ ObjectSpace space, AllocationAction action));
/**
* Removes callback that was installed by AddMemoryAllocationCallback.
*/
- void RemoveMemoryAllocationCallback(MemoryAllocationCallback callback);
+ void V8_DEPRECATED(
+ "Use a combination of RequestInterrupt and GCCallback instead",
+ RemoveMemoryAllocationCallback(MemoryAllocationCallback callback));
/**
* Iterates through all external resources referenced from current isolate
@@ -6468,23 +6472,6 @@ class V8_EXPORT V8 {
void RemoveGCEpilogueCallback(GCCallback callback));
/**
- * Enables the host application to provide a mechanism to be notified
- * and perform custom logging when V8 Allocates Executable Memory.
- */
- V8_INLINE static V8_DEPRECATED(
- "Use isolate version",
- void AddMemoryAllocationCallback(MemoryAllocationCallback callback,
- ObjectSpace space,
- AllocationAction action));
-
- /**
- * Removes callback that was installed by AddMemoryAllocationCallback.
- */
- V8_INLINE static V8_DEPRECATED(
- "Use isolate version",
- void RemoveMemoryAllocationCallback(MemoryAllocationCallback callback));
-
- /**
* Initializes V8. This function needs to be called before the first Isolate
* is created. It always returns true.
*/
@@ -8704,21 +8691,6 @@ void V8::RemoveGCEpilogueCallback(GCCallback callback) {
reinterpret_cast<v8::Isolate::GCCallback>(callback));
}
-
-void V8::AddMemoryAllocationCallback(MemoryAllocationCallback callback,
- ObjectSpace space,
- AllocationAction action) {
- Isolate* isolate = Isolate::GetCurrent();
- isolate->AddMemoryAllocationCallback(callback, space, action);
-}
-
-
-void V8::RemoveMemoryAllocationCallback(MemoryAllocationCallback callback) {
- Isolate* isolate = Isolate::GetCurrent();
- isolate->RemoveMemoryAllocationCallback(callback);
-}
-
-
void V8::TerminateExecution(Isolate* isolate) { isolate->TerminateExecution(); }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698