Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1886453002: GN: Use std::unique_ptr for owned pointers in ImportManager. (Closed)

Created:
4 years, 8 months ago by jbroman
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use std::unique_ptr for owned pointers in ImportManager. BUG=602726 Committed: https://crrev.com/647a1af223628bb4e15b69a29ca257477282b737 Cr-Commit-Position: refs/heads/master@{#387997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M tools/gn/import_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gn/import_manager.cc View 6 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886453002/1
4 years, 8 months ago (2016-04-18 18:11:45 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 18:50:27 UTC) #4
jbroman
4 years, 8 months ago (2016-04-18 19:10:17 UTC) #7
brettw
lgtm
4 years, 8 months ago (2016-04-18 19:49:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886453002/1
4 years, 8 months ago (2016-04-18 20:03:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 20:14:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:15:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/647a1af223628bb4e15b69a29ca257477282b737
Cr-Commit-Position: refs/heads/master@{#387997}

Powered by Google App Engine
This is Rietveld 408576698