tools/gn/import_manager.h - Issue 1886453002: GN: Use std::unique_ptr for owned pointers in ImportManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/import_manager.h

Issue 1886453002: GN: Use std::unique_ptr for owned pointers in ImportManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/import_manager.h

diff --git a/tools/gn/import_manager.h b/tools/gn/import_manager.h

index 70aeee727c507b771c0b4090af5f273e4717ca14..bd47a2ad519989ce6ff93087b60069ea54b200f5 100644

--- a/tools/gn/import_manager.h

+++ b/tools/gn/import_manager.h

@@ -6,6 +6,7 @@

#define TOOLS_GN_IMPORT_MANAGER_H_

#include <map>

+#include <memory>

#include "base/macros.h"

#include "base/synchronization/lock.h"

@@ -33,7 +34,7 @@ class ImportManager {

base::Lock lock_;

// Owning pointers to the scopes.

- typedef std::map<SourceFile, const Scope*> ImportMap;

+ typedef std::map<SourceFile, std::unique_ptr<const Scope>> ImportMap;

ImportMap imports_;

DISALLOW_COPY_AND_ASSIGN(ImportManager);

« no previous file with comments | « no previous file | tools/gn/import_manager.cc » ('j') | no next file with comments »