Issue 188643006: Revert 255322 "ThreadWatcher: fixes Start/StopWatchingAll."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 188643006: Revert 255322 "ThreadWatcher: fixes Start/StopWatchingAll." (Closed)

Created:
6 years, 9 months ago by oshima

Modified:
6 years, 9 months ago

Reviewers:
bulach

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 255322 "ThreadWatcher: fixes Start/StopWatchingAll." > ThreadWatcher: fixes Start/StopWatchingAll. > > Start is deferred in relation to Stop, and when they're both called > within the Start interval, the end result was started. > > BUG=347887 > TEST=unit_tests --gtest_filter=ThreadWatcherList* > > Review URL: https://codereview.chromium.org/183063007 BUG=347887, 349987 TBR=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255401

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -82 lines)			Patch
M	trunk/src/chrome/browser/metrics/thread_watcher.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/metrics/thread_watcher.cc	View	5 chunks	+0 lines, -21 lines	0 comments	Download
M	trunk/src/chrome/browser/metrics/thread_watcher_unittest.cc	View	2 chunks	+0 lines, -51 lines	0 comments	Download

Total messages: 2 (0 generated)

oshima

6 years, 9 months ago (2014-03-06 18:33:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r255401 (tree was closed).