Issue 183063007: ThreadWatcher: fixes Start/StopWatchingAll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183063007: ThreadWatcher: fixes Start/StopWatchingAll. (Closed)

Created:
6 years, 9 months ago by bulach

Modified:
6 years, 9 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ThreadWatcher: fixes Start/StopWatchingAll. Start is deferred in relation to Stop, and when they're both called within the Start interval, the end result was started. BUG=347887 TEST=unit_tests --gtest_filter=ThreadWatcherList* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255322

Patch Set 1 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -0 lines)			Patch
M	chrome/browser/metrics/thread_watcher.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/metrics/thread_watcher.cc	View	5 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/metrics/thread_watcher_unittest.cc	View	2 chunks	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/183063007/20001

6 years, 9 months ago (2014-03-06 10:49:19 UTC) #4

Message was sent while issue was closed.

Change committed as 255322

Expand Messages | Collapse Messages