Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 188603002: Fix base::internal::Singleton to use acquire loads instead of nobarrier ones. (Closed)

Created:
6 years, 9 months ago by Alexander Potapenko
Modified:
6 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Fix base::internal::Singleton to use acquire loads instead of nobarrier ones. The NoBarrier_Load operations don't actually guarantee that the singleton data associated with the pointer is visible to the thread calling get() even if the pointer is initialized. R=mark@chromium.org, dvyukov@chromium.org, epenner@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M base/memory/singleton.h View 2 chunks +4 lines, -1 line 0 comments Download
M base/memory/singleton.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Alexander Potapenko
Please take a look.
6 years, 9 months ago (2014-03-06 12:41:46 UTC) #1
Mark Mentovai
LGTM
6 years, 9 months ago (2014-03-06 14:28:59 UTC) #2
Dmitry Vyukov
LGTM
6 years, 9 months ago (2014-03-06 14:36:28 UTC) #3
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 9 months ago (2014-03-07 05:22:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/188603002/1
6 years, 9 months ago (2014-03-07 05:24:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 05:54:27 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=54027
6 years, 9 months ago (2014-03-07 05:54:27 UTC) #7
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 9 months ago (2014-03-07 07:03:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/188603002/1
6 years, 9 months ago (2014-03-07 07:05:26 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 07:26:15 UTC) #10
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=54042
6 years, 9 months ago (2014-03-07 07:26:15 UTC) #11
Alexander Potapenko
6 years, 9 months ago (2014-03-07 08:51:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 manually as r255552.

Powered by Google App Engine
This is Rietveld 408576698