Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 1886003002: [Media Router WebUI] Use I18nBehavior to retrieve strings. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, media-router+watch_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Use I18nBehavior to retrieve strings. This change uses the I18nBehavior rather than calling loadTimeData.getString() for most of the strings when elements are initially created. On Linux using a debug build, the UI load time is: - before change: 3579.66ms (average 20 runs) - after change: 3440.15ms (average 20 runs) There is a 3.9% decrease in initial load time observed. BUG=549289 Committed: https://crrev.com/26f90a390c9a8bab54c410c3ec60b52c7372b1eb Cr-Commit-Position: refs/heads/master@{#387081}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -99 lines) Patch
M chrome/browser/resources/media_router/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js View 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html View 8 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 4 chunks +17 lines, -33 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js View 2 chunks +4 lines, -21 lines 0 comments Download
M chrome/browser/resources/media_router/elements/route_details/route_details.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/media_router/elements/route_details/route_details.js View 2 chunks +4 lines, -21 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
apacible
PTAL, thanks!
4 years, 8 months ago (2016-04-13 19:29:43 UTC) #7
mark a. foltz
lgtm
4 years, 8 months ago (2016-04-13 19:56:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886003002/20001
4 years, 8 months ago (2016-04-13 20:03:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/50403)
4 years, 8 months ago (2016-04-13 20:16:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886003002/20001
4 years, 8 months ago (2016-04-13 20:50:46 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-13 20:57:57 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 20:59:57 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26f90a390c9a8bab54c410c3ec60b52c7372b1eb
Cr-Commit-Position: refs/heads/master@{#387081}

Powered by Google App Engine
This is Rietveld 408576698