chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js - Issue 1886003002: [Media Router WebUI] Use I18nBehavior to retrieve strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

Issue 1886003002: [Media Router WebUI] Use I18nBehavior to retrieve strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html ('k') | chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

diff --git a/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js b/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

index f897b0e41d13a7a6610796f8864c77b36ba26fbb..855931bac31e5d5c2571e9a2b4279fb209ab1006 100644

--- a/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

+++ b/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

@@ -52,6 +52,10 @@ Polymer({

+ behaviors: [

+ I18nBehavior,

+ ],

/**

* @param {?media_router.Issue} issue

* @return {boolean} Whether or not to hide the blocking issue UI.

@@ -127,14 +131,14 @@ Polymer({

var defaultText = '';

var secondaryText = '';

if (this.issue) {

- defaultText = loadTimeData.getString(

- this.actionTypeToButtonTextResource_[

- this.issue.defaultActionType]);

+ defaultText =

+ this.i18n(this.actionTypeToButtonTextResource_[

+ this.issue.defaultActionType]);

if (this.issue.secondaryActionType) {

- secondaryText = loadTimeData.getString(

- this.actionTypeToButtonTextResource_[

- this.issue.secondaryActionType]);

+ secondaryText =

+ this.i18n(this.actionTypeToButtonTextResource_[

+ this.issue.secondaryActionType]);

}