[css-grid] Use grid-template-areas to determine the explicit grid

[css-grid] Use grid-template-areas to determine the explicit grid

From the spec (https://drafts.csswg.org/css-grid/#grid-definition):
"The size of the explicit grid is determined by the larger of the number
 of rows/columns defined by grid-template-areas and the number
 of rows/columns sized by grid-template-rows/grid-template-columns."

So we need to take into account the rows/columns defined by
grid-template-areas to determine the size of the explicit grid.

On top of that this patch is also taking into account this
in LayoutGrid::explicitGridDidResize().

Created a new test to check the right behavior and added new test cases
to check the style changes too.

BUG=603160
TEST=fast/css-grid-layout/explicit-grid-size.html

Committed: https://crrev.com/2b77da3c2afb9ef469d69a52250e7769ae74aca1
Cr-Commit-Position: refs/heads/master@{#387261}

[Manuel Rego, 2016-04-13 17:01:16]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[cbiesinger, 2016-04-13 19:49:55]

lgtm

[Manuel Rego, 2016-04-13 20:02:44]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-04-13 20:02:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885913002/1

[commit-bot: I haz the power, 2016-04-13 20:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:15:14]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Manuel Rego, 2016-04-13 20:22:54]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-04-13 20:23:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885913002/1

[commit-bot: I haz the power, 2016-04-13 21:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 21:04:32]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Manuel Rego, 2016-04-14 07:04:45]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-04-14 07:05:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885913002/1

[svillar, 2016-04-14 07:36:57]

non-lgtm. The patch is wrong because it breaks gridTrackSize() resolution as you
are not considering the tracks implicitly created by the grid-template-areas
definition that are not in grid-template-rows|columns.

[svillar, 2016-04-14 07:37:27]

On 2016/04/14 07:36:57, svillar wrote:
> non-lgtm. The patch is wrong because it breaks gridTrackSize() resolution as
you
> are not considering the tracks implicitly created by the grid-template-areas
> definition that are not in grid-template-rows|columns.

I mean no lgtm

[Manuel Rego, 2016-04-14 07:43:24]

The CQ bit was unchecked by rego@igalia.com

[svillar, 2016-04-14 07:45:52]

On 2016/04/14 07:37:27, svillar wrote:
> On 2016/04/14 07:36:57, svillar wrote:
> > non-lgtm. The patch is wrong because it breaks gridTrackSize() resolution as
> you
> > are not considering the tracks implicitly created by the grid-template-areas
> > definition that are not in grid-template-rows|columns.
> 
> I mean no lgtm

It looks like I missunderstood the specs. The tracks in grid-template-areas that
are not in grid-template-* should take their value from grid-auto-* properties,
so we're doing fine. lgtm

[Manuel Rego, 2016-04-14 07:49:35]

On 2016/04/14 07:45:52, svillar wrote:
> It looks like I missunderstood the specs. The tracks in grid-template-areas
that
> are not in grid-template-* should take their value from grid-auto-*
properties,
> so we're doing fine. lgtm

Just to clarify the thing quoting the spec:
"Any rows/columns defined by grid-template-areas but not sized
 by grid-template-rows/grid-template-columns take their size
 from the grid-auto-rows/grid-auto-columns properties."

BTW, the patch has tests exactly checking this.

[Manuel Rego, 2016-04-14 07:49:42]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-04-14 07:49:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885913002/1

[commit-bot: I haz the power, 2016-04-14 08:31:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-14 08:32:40]

Description was changed from

==========
[css-grid] Use grid-template-areas to determine the explicit grid

From the spec (https://drafts.csswg.org/css-grid/#grid-definition):
"The size of the explicit grid is determined by the larger of the number
 of rows/columns defined by grid-template-areas and the number
 of rows/columns sized by grid-template-rows/grid-template-columns."

So we need to take into account the rows/columns defined by
grid-template-areas to determine the size of the explicit grid.

On top of that this patch is also taking into account this
in LayoutGrid::explicitGridDidResize().

Created a new test to check the right behavior and added new test cases
to check the style changes too.

BUG=603160
TEST=fast/css-grid-layout/explicit-grid-size.html
==========

to

==========
[css-grid] Use grid-template-areas to determine the explicit grid

From the spec (https://drafts.csswg.org/css-grid/#grid-definition):
"The size of the explicit grid is determined by the larger of the number
 of rows/columns defined by grid-template-areas and the number
 of rows/columns sized by grid-template-rows/grid-template-columns."

So we need to take into account the rows/columns defined by
grid-template-areas to determine the size of the explicit grid.

On top of that this patch is also taking into account this
in LayoutGrid::explicitGridDidResize().

Created a new test to check the right behavior and added new test cases
to check the style changes too.

BUG=603160
TEST=fast/css-grid-layout/explicit-grid-size.html

Committed: https://crrev.com/2b77da3c2afb9ef469d69a52250e7769ae74aca1
Cr-Commit-Position: refs/heads/master@{#387261}
==========

[commit-bot: I haz the power, 2016-04-14 08:32:42]

Patchset 1 (id:??) landed as
https://crrev.com/2b77da3c2afb9ef469d69a52250e7769ae74aca1
Cr-Commit-Position: refs/heads/master@{#387261}