third_party/WebKit/Source/core/layout/LayoutGrid.cpp - Issue 1885913002: [css-grid] Use grid-template-areas to determine the explicit grid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 1885913002: [css-grid] Use grid-template-areas to determine the explicit grid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt ('k') | third_party/WebKit/Source/core/style/GridPositionsResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

index c289e73157282f2d53cb848b2e832d14ca529527..0e731899b345173206ba6cd948c03df045b032ba 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

@@ -308,7 +308,9 @@ void LayoutGrid::styleDidChange(StyleDifference diff, const ComputedStyle* oldSt

bool LayoutGrid::explicitGridDidResize(const ComputedStyle& oldStyle) const

{

return oldStyle.gridTemplateColumns().size() != styleRef().gridTemplateColumns().size()

- || oldStyle.gridTemplateRows().size() != styleRef().gridTemplateRows().size();

+ || oldStyle.gridTemplateRows().size() != styleRef().gridTemplateRows().size()

+ || oldStyle.namedGridAreaColumnCount() != styleRef().namedGridAreaColumnCount()

+ || oldStyle.namedGridAreaRowCount() != styleRef().namedGridAreaRowCount();

}

bool LayoutGrid::namedGridLinesDefinitionDidChange(const ComputedStyle& oldStyle) const