Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1885883002: Gerrit git cl upload: implement setting cc and reviewers. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
Reviewers:
Bons, Michael Achenbach
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@R400
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M git_cl.py View 1 1 chunk +5 lines, -13 lines 0 comments Download
M tests/git_cl_test.py View 1 1 chunk +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1886433003 Patch 20001

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885883002/1
4 years, 8 months ago (2016-04-13 12:39:49 UTC) #2
tandrii(chromium)
4 years, 8 months ago (2016-04-13 12:39:49 UTC) #3
Michael Achenbach
lgtm https://codereview.chromium.org/1885883002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1885883002/diff/1/git_cl.py#newcode2394 git_cl.py:2394: cc = self.GetCCList().split(',') Can there be spaces after ...
4 years, 8 months ago (2016-04-13 12:43:04 UTC) #4
Bons
lgtm https://codereview.chromium.org/1885883002/diff/1/tests/git_cl_test.py File tests/git_cl_test.py (right): https://codereview.chromium.org/1885883002/diff/1/tests/git_cl_test.py#newcode810 tests/git_cl_test.py:810: ref_suffix += ',' + ','.join('r=%s' % email for ...
4 years, 8 months ago (2016-04-13 12:44:03 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/203)
4 years, 8 months ago (2016-04-13 12:45:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885883002/20001
4 years, 8 months ago (2016-04-13 12:53:09 UTC) #10
tandrii(chromium)
https://codereview.chromium.org/1885883002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1885883002/diff/1/git_cl.py#newcode2394 git_cl.py:2394: cc = self.GetCCList().split(',') On 2016/04/13 12:43:04, Michael Achenbach wrote: ...
4 years, 8 months ago (2016-04-13 12:53:14 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 12:56:04 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299887

Powered by Google App Engine
This is Rietveld 408576698