Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tests/git_cl_test.py

Issue 1885883002: Gerrit git cl upload: implement setting cc and reviewers. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@R400
Patch Set: review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index cbeec08abbbed8b769c99e7230d45b97a0b6d408..4797288258f946f4e363d82be8d850e39e45b99d 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -801,16 +801,16 @@ class TestGitCl(TestCase):
expected_upstream_ref + '..' + ref_to_push],), ''),
((['git', 'config', 'rietveld.cc'],), '')
]
- receive_pack = '--receive-pack=git receive-pack '
- receive_pack += '--cc=joe@example.com' # from watch list
+ # Add cc from watch list.
+ if ref_suffix == '':
+ ref_suffix = '%cc=joe@example.com'
+ else:
+ ref_suffix += ',cc=joe@example.com'
if reviewers:
- receive_pack += ' '
- receive_pack += ' '.join(
- '--reviewer=' + email for email in sorted(reviewers))
- receive_pack += ''
+ ref_suffix += ',' + ','.join('r=%s' % email
+ for email in sorted(reviewers))
calls += [
- ((['git',
- 'push', receive_pack, 'origin',
+ ((['git', 'push', 'origin',
ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
('remote:\n'
'remote: Processing changes: (\)\n'
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698