src/gpu/effects/GrConvolutionEffect.cpp - Issue 1885863004: Refactor how we store and use samplers in Ganesh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConvolutionEffect.cpp

Issue 1885863004: Refactor how we store and use samplers in Ganesh (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConvolutionEffect.cpp

diff --git a/src/gpu/effects/GrConvolutionEffect.cpp b/src/gpu/effects/GrConvolutionEffect.cpp

index 9567e4c2214dc703751208d3cdbb84b4fae03ff8..c7797c2edbb7b0159644528795ea2fc36ebd7dc9 100644

--- a/src/gpu/effects/GrConvolutionEffect.cpp

+++ b/src/gpu/effects/GrConvolutionEffect.cpp

@@ -82,7 +82,7 @@ void GrGLConvolutionEffect::emitCode(EmitArgs& args) {

component, bounds, component, bounds);

}

fragBuilder->codeAppendf("\t\t%s += ", args.fOutputColor);

- fragBuilder->appendTextureLookup(args.fTexSamplers[0], "coord");

+ fragBuilder->appendTextureLookup(uniformHandler->getSampler(args.fTexSamplers[0]), "coord");

fragBuilder->codeAppendf(" * %s;\n", kernelIndex.c_str());

if (ce.useBounds()) {

fragBuilder->codeAppend("}");