src/gpu/effects/GrBicubicEffect.cpp - Issue 1885863004: Refactor how we store and use samplers in Ganesh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrBicubicEffect.cpp

Issue 1885863004: Refactor how we store and use samplers in Ganesh (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrBicubicEffect.cpp

diff --git a/src/gpu/effects/GrBicubicEffect.cpp b/src/gpu/effects/GrBicubicEffect.cpp

index 0a06b62c416e14c01f683af12befb47d09994065..82fabac73b280ce66754f39c7f355b8789d35cd8 100644

--- a/src/gpu/effects/GrBicubicEffect.cpp

+++ b/src/gpu/effects/GrBicubicEffect.cpp

@@ -99,7 +99,7 @@ void GrGLBicubicEffect::emitCode(EmitArgs& args) {

domain,

sampleVar.c_str(),

coord,

- args.fTexSamplers[0]);

+ uniformHandler->getSampler(args.fTexSamplers[0]));

}

fragBuilder->codeAppendf(

"\tvec4 s%d = %s(%s, f.x, rowColors[0], rowColors[1], rowColors[2], rowColors[3]);\n",