src/effects/SkMorphologyImageFilter.cpp - Issue 1885863004: Refactor how we store and use samplers in Ganesh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMorphologyImageFilter.cpp

Issue 1885863004: Refactor how we store and use samplers in Ganesh (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMorphologyImageFilter.cpp

diff --git a/src/effects/SkMorphologyImageFilter.cpp b/src/effects/SkMorphologyImageFilter.cpp

index d0ca20576b381301dc47b06075927d55fe6a7fa0..a98b89e5cc2bd1f087452f3688c56992aa30bec9 100644

--- a/src/effects/SkMorphologyImageFilter.cpp

+++ b/src/effects/SkMorphologyImageFilter.cpp

@@ -239,7 +239,7 @@ void GrGLMorphologyEffect::emitCode(EmitArgs& args) {

}

fragBuilder->codeAppendf("\t\tfor (int i = 0; i < %d; i++) {\n", width);

fragBuilder->codeAppendf("\t\t\t%s = %s(%s, ", args.fOutputColor, func, args.fOutputColor);

- fragBuilder->appendTextureLookup(args.fTexSamplers[0], "coord");

+ fragBuilder->appendTextureLookup(uniformHandler->getSampler(args.fTexSamplers[0]), "coord");

fragBuilder->codeAppend(");\n");

// coord.x += pixelSize;

fragBuilder->codeAppendf("\t\t\tcoord.%s += %s;\n", dir, pixelSizeInc);