src/effects/SkMagnifierImageFilter.cpp - Issue 1885863004: Refactor how we store and use samplers in Ganesh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMagnifierImageFilter.cpp

Issue 1885863004: Refactor how we store and use samplers in Ganesh (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMagnifierImageFilter.cpp

diff --git a/src/effects/SkMagnifierImageFilter.cpp b/src/effects/SkMagnifierImageFilter.cpp

index 50e17d424672cd72895c8b29347b6e63616a0d9f..0c21de2cae9baae81e9b1cfb8daba5aef3f56ddb 100644

--- a/src/effects/SkMagnifierImageFilter.cpp

+++ b/src/effects/SkMagnifierImageFilter.cpp

@@ -155,7 +155,7 @@ void GrGLMagnifierEffect::emitCode(EmitArgs& args) {

fragBuilder->codeAppend("\t\tvec2 mix_coord = mix(coord, zoom_coord, weight);\n");

fragBuilder->codeAppend("\t\tvec4 output_color = ");

- fragBuilder->appendTextureLookup(args.fTexSamplers[0], "mix_coord");

+ fragBuilder->appendTextureLookup(uniformHandler->getSampler(args.fTexSamplers[0]), "mix_coord");

fragBuilder->codeAppend(";\n");

fragBuilder->codeAppendf("\t\t%s = output_color;", args.fOutputColor);