src/effects/SkLightingImageFilter.cpp - Issue 1885863004: Refactor how we store and use samplers in Ganesh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 1885863004: Refactor how we store and use samplers in Ganesh (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index e60e7ed370b4c4c4c009eb7f1c412e2a0187104a..7adcd24b5aec4b1a68b088cc3f272f886557e6c3 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -1824,7 +1824,7 @@ void GrGLLightingEffect::emitCode(EmitArgs& args) {

le.domain(),

temp.c_str(),

texCoords,

- args.fTexSamplers[0]);

+ uniformHandler->getSampler(args.fTexSamplers[0]));

fragBuilder->codeAppendf("m[%d] = %s.a;", index, temp.c_str());

index++;

}