Fix bug: MIDI causes crash on onContentSettingChanged()

Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there
isn't corresponding content setting. Skip it because MIDI is constant permission
and it never changes anyway.

BUG=599060
Committed: https://crrev.com/3c02c9483d9b17a50f9a9dd45a72f8da4a7c4c73
Cr-Commit-Position: refs/heads/master@{#387174}

[lshang, 2016-04-13 03:39:09]

Description was changed from

==========
Fix bug: MIDI causes crash on onContentSettingChanged()


skip MIDI

BUG=599060
==========

to

==========
Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there
isn't corresponding content setting. Skip it because MIDI is constant permission
and it never changes anyway.

BUG=599060
==========

[lshang, 2016-04-13 03:39:25]

Description was changed from

==========
Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there
isn't corresponding content setting. Skip it because MIDI is constant permission
and it never changes anyway.

BUG=599060
==========

to

==========
Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there 
isn't corresponding content setting. Skip it because MIDI is constant permission

and it never changes anyway.

BUG=599060
==========

[lshang, 2016-04-13 03:40:43]

lshang@chromium.org changed reviewers:
+ raymes@chromium.org

[lshang, 2016-04-13 03:40:43]

PTAL thanks!

[raymes, 2016-04-13 04:11:35]

raymes@chromium.org changed reviewers:
+ mlamouri@chromium.org

[raymes, 2016-04-13 04:11:36]

Thanks Liu. We should probably add a simple test to
permission_manager_unittest.cc, similar to SameTypeChangeNotifies.

https://codereview.chromium.org/1885823002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_manager.cc (right):

https://codereview.chromium.org/1885823002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_manager.cc:403: }
nit: no {}

[lshang, 2016-04-13 06:31:06]

On 2016/04/13 04:11:36, raymes wrote:
> Thanks Liu. We should probably add a simple test to
> permission_manager_unittest.cc, similar to SameTypeChangeNotifies.
> 

Done.

>
https://codereview.chromium.org/1885823002/diff/1/chrome/browser/permissions/...
> File chrome/browser/permissions/permission_manager.cc (right):
> 
>
https://codereview.chromium.org/1885823002/diff/1/chrome/browser/permissions/...
> chrome/browser/permissions/permission_manager.cc:403: }
> nit: no {}

Done.

[mlamouri (slow - plz ping), 2016-04-13 12:48:44]

lgtm

[lshang, 2016-04-13 23:59:31]

The CQ bit was checked by lshang@chromium.org

[commit-bot: I haz the power, 2016-04-14 00:00:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885823002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885823002/40001

[commit-bot: I haz the power, 2016-04-14 00:36:08]

Description was changed from

==========
Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there 
isn't corresponding content setting. Skip it because MIDI is constant permission

and it never changes anyway.

BUG=599060
==========

to

==========
Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there 
isn't corresponding content setting. Skip it because MIDI is constant permission

and it never changes anyway.

BUG=599060
==========

[commit-bot: I haz the power, 2016-04-14 00:36:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-14 00:38:22]

Description was changed from

==========
Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there 
isn't corresponding content setting. Skip it because MIDI is constant permission

and it never changes anyway.

BUG=599060
==========

to

==========
Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there
isn't corresponding content setting. Skip it because MIDI is constant permission
and it never changes anyway.

BUG=599060

Committed: https://crrev.com/3c02c9483d9b17a50f9a9dd45a72f8da4a7c4c73
Cr-Commit-Position: refs/heads/master@{#387174}
==========

[commit-bot: I haz the power, 2016-04-14 00:38:24]

Patchset 3 (id:??) landed as
https://crrev.com/3c02c9483d9b17a50f9a9dd45a72f8da4a7c4c73
Cr-Commit-Position: refs/heads/master@{#387174}