Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/permissions/permission_manager_unittest.cc

Issue 1885823002: Fix bug: MIDI causes crash on onContentSettingChanged() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove {} Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_manager_unittest.cc
diff --git a/chrome/browser/permissions/permission_manager_unittest.cc b/chrome/browser/permissions/permission_manager_unittest.cc
index c780aaf60222933bac2d3fc2a72683fcc29490c2..2916cfbda4d2d737c2fd447dbeea48c4377711c4 100644
--- a/chrome/browser/permissions/permission_manager_unittest.cc
+++ b/chrome/browser/permissions/permission_manager_unittest.cc
@@ -301,3 +301,20 @@ TEST_F(PermissionManagerTest, ChangesBackAndForth) {
GetPermissionManager()->UnsubscribePermissionStatusChange(subscription_id);
}
+
+TEST_F(PermissionManagerTest, SubscribeMIDIPermission) {
+ int subscription_id = GetPermissionManager()->SubscribePermissionStatusChange(
+ PermissionType::MIDI, url(), url(),
+ base::Bind(&PermissionManagerTest::OnPermissionChange,
+ base::Unretained(this)));
+
+ CheckPermissionStatus(PermissionType::GEOLOCATION, PermissionStatus::ASK);
+ GetHostContentSettingsMap()->SetContentSettingDefaultScope(
+ url(), url(), CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string(),
+ CONTENT_SETTING_ALLOW);
+ CheckPermissionStatus(PermissionType::GEOLOCATION, PermissionStatus::GRANTED);
+
+ EXPECT_FALSE(callback_called());
+
+ GetPermissionManager()->UnsubscribePermissionStatusChange(subscription_id);
+}
« no previous file with comments | « chrome/browser/permissions/permission_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698