Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2573)

Unified Diff: chrome/browser/printing/pdf_to_emf_converter.cc

Issue 1885813002: Delete the utility process startup ping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/pdf_to_emf_converter.cc
diff --git a/chrome/browser/printing/pdf_to_emf_converter.cc b/chrome/browser/printing/pdf_to_emf_converter.cc
index e16963f98343c0ffee9f021df940a5f39f7bd059..bcc4e3ac72de806decda242dca6e4948c1e3976b 100644
--- a/chrome/browser/printing/pdf_to_emf_converter.cc
+++ b/chrome/browser/printing/pdf_to_emf_converter.cc
@@ -154,7 +154,6 @@ class PdfToEmfUtilityProcessHostClient
bool Send(IPC::Message* msg);
// Message handlers.
- void OnProcessStarted();
void OnPageCount(int page_count);
void OnPageDone(bool success, float scale_factor);
@@ -167,7 +166,6 @@ class PdfToEmfUtilityProcessHostClient
// Used to suppress callbacks after PdfToEmfConverterImpl is deleted.
base::WeakPtr<PdfToEmfConverterImpl> converter_;
PdfRenderSettings settings_;
- scoped_refptr<base::RefCountedMemory> data_;
// Document loaded callback.
PdfToEmfConverter::StartCallback start_callback_;
@@ -301,7 +299,6 @@ void PdfToEmfUtilityProcessHostClient::Start(
start_callback));
return;
}
- data_ = data;
// Store callback before any OnFailed() call to make it called on failure.
start_callback_ = start_callback;
@@ -314,17 +311,7 @@ void PdfToEmfUtilityProcessHostClient::Start(
this, base::MessageLoop::current()->task_runner())->AsWeakPtr();
utility_process_host_->SetName(l10n_util::GetStringUTF16(
IDS_UTILITY_PROCESS_EMF_CONVERTOR_NAME));
- // Should reply with OnProcessStarted().
- Send(new ChromeUtilityMsg_StartupPing);
-}
-
-void PdfToEmfUtilityProcessHostClient::OnProcessStarted() {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- if (!utility_process_host_)
- return OnFailed();
- scoped_refptr<base::RefCountedMemory> data = data_;
- data_ = NULL;
BrowserThread::PostTaskAndReplyWithResult(
BrowserThread::FILE,
FROM_HERE,
@@ -446,7 +433,6 @@ bool PdfToEmfUtilityProcessHostClient::OnMessageReceived(
const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(PdfToEmfUtilityProcessHostClient, message)
- IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ProcessStarted, OnProcessStarted)
IPC_MESSAGE_HANDLER(
ChromeUtilityHostMsg_RenderPDFPagesToMetafiles_PageCount, OnPageCount)
IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_RenderPDFPagesToMetafiles_PageDone,

Powered by Google App Engine
This is Rietveld 408576698