Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc

Issue 1885813002: Delete the utility process startup ping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc
diff --git a/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc b/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc
index f45d5aa968afa237da2cd2e38ca7ae2eb3438f9d..0533edb60527be3362d44f940191521a997ca0a9 100644
--- a/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc
+++ b/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc
@@ -71,20 +71,7 @@ void SafePicasaAlbumTableReader::StartWorkOnIOThread() {
->AsWeakPtr();
utility_process_host_->SetName(l10n_util::GetStringUTF16(
IDS_UTILITY_PROCESS_MEDIA_LIBRARY_FILE_CHECKER_NAME));
- // Wait for the startup notification before sending the main IPC to the
- // utility process, so that we can dup the file handle.
- utility_process_host_->Send(new ChromeUtilityMsg_StartupPing);
- parser_state_ = PINGED_UTILITY_PROCESS_STATE;
-}
-void SafePicasaAlbumTableReader::OnProcessStarted() {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- if (parser_state_ != PINGED_UTILITY_PROCESS_STATE)
- return;
-
- if (utility_process_host_->GetData().handle == base::kNullProcessHandle) {
- DLOG(ERROR) << "Child process handle is null";
- }
AlbumTableFilesForTransit files_for_transit;
files_for_transit.indicator_file = IPC::TakePlatformFileForTransit(
std::move(album_table_files_.indicator_file));
@@ -129,8 +116,6 @@ bool SafePicasaAlbumTableReader::OnMessageReceived(
const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(SafePicasaAlbumTableReader, message)
- IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ProcessStarted,
- OnProcessStarted)
IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParsePicasaPMPDatabase_Finished,
OnParsePicasaPMPDatabaseFinished)
IPC_MESSAGE_UNHANDLED(handled = false)

Powered by Google App Engine
This is Rietveld 408576698