Implement MIDIOutput.send()

Implement MIDIOutput.send()

This fully implements the Web MIDI API sending of MIDI data in Blink, but further work is still
needed in the chromium back-end.

BUG=163795
TEST=requestmidiaccess.html updated to test send() method
R=abarth@chromium.org, toyoshim@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154697

[Takashi Toyoshima, 2013-07-09 10:19:11]

https://codereview.chromium.org/18858006/diff/2001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIAccess.cpp (right):

https://codereview.chromium.org/18858006/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIAccess.cpp:124: if (data[0] >= 0xf0 &&
!m_midiOptions.sysex)
It should raise SecurityError if it detects forbidden sysex access.

Also this is just a comment for the future work.
It may be better to have this check in MIDIOutput class. We'll implement MIDI
protocol parser to complement running statuses in MIDIOutput since it depends on
MIDI port contexts. So sysex checker can be merged to the parser.

[Chris Rogers, 2013-07-17 21:28:12]

PTAL

https://codereview.chromium.org/18858006/diff/2001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIAccess.cpp (right):

https://codereview.chromium.org/18858006/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIAccess.cpp:124: if (data[0] >= 0xf0 &&
!m_midiOptions.sysex)
On 2013/07/09 10:19:11, Takashi Toyoshima (chromium) wrote:
> It should raise SecurityError if it detects forbidden sysex access.
> 
> Also this is just a comment for the future work.
> It may be better to have this check in MIDIOutput class. We'll implement MIDI
> protocol parser to complement running statuses in MIDIOutput since it depends
on
> MIDI port contexts. So sysex checker can be merged to the parser.

Done.  Now raising SecurityError

Also moved this check into MIDIOutput

[Takashi Toyoshima, 2013-07-22 07:32:53]

LGTM.

[commit-bot: I haz the power, 2013-07-22 17:16:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/crogers@google.com/18858006/8001

[commit-bot: I haz the power, 2013-07-22 17:27:02]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Chris Rogers, 2013-07-22 17:42:13]

+abarth: for OWNERS review

[abarth-chromium, 2013-07-22 18:18:00]

Source/web LGTM

[commit-bot: I haz the power, 2013-07-22 18:49:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/crogers@google.com/18858006/8001

[commit-bot: I haz the power, 2013-07-22 20:52:34]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Chris Rogers, 2013-07-23 00:07:32]

Committed patchset #5 manually as r154697 (presubmit successful).

[Chris Evans, 2013-07-23 01:23:54]

On 2013/07/23 00:07:32, Chris Rogers wrote:
> Committed patchset #5 manually as r154697 (presubmit successful).

It looks like this change may have wrecked try job productivity. I wonder why it
was committed manually after commit-bot indicated a compile error?