Implement MIDIOutput.send()

Source/modules/webmidi/MIDIAccess.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 42 matching lines @@
 
 MIDIAccess::~MIDIAccess()
 {
     stop();
 }
 
 MIDIAccess::MIDIAccess(ScriptExecutionContext* context, MIDIAccessPromise* promise)
     : ActiveDOMObject(context)
     , m_promise(promise)
     , m_hasAccess(false)
+    , m_midiOptions(*promise->options())
 {
     ScriptWrappable::init(this);
     m_accessor = MIDIAccessor::create(this);
-    m_accessor->requestAccess(promise->options()->sysex);
+    m_accessor->requestAccess(m_midiOptions.sysex);
 }
 
 void MIDIAccess::didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version)
 {
     ASSERT(isMainThread());
 
     m_inputs.append(MIDIInput::create(scriptExecutionContext(), id, manufacturer, name, version));
 }
 
 void MIDIAccess::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version)
 {
     ASSERT(isMainThread());
 
-    m_outputs.append(MIDIOutput::create(scriptExecutionContext(), id, manufacturer, name, version));
+    unsigned portIndex = m_outputs.size();
+    m_outputs.append(MIDIOutput::create(this, portIndex, scriptExecutionContext(), id, manufacturer, name, version));
 }
 
 void MIDIAccess::didAllowAccess()
 {
     ASSERT(isMainThread());
 
     m_hasAccess = true;
     m_promise->fulfill();
 }
 
@@ skipping 16 matching lines @@
         // This is how timestamps are defined in the Web MIDI spec.
         Document* document = toDocument(scriptExecutionContext());
         ASSERT(document);
 
         double timeStampInMilliseconds = 1000 * document->loader()->timing()->monotonicTimeToZeroBasedDocumentTime(timeStamp);
 
         m_inputs[portIndex]->didReceiveMIDIData(portIndex, data, length, timeStampInMilliseconds);
     }
 }
 
+void MIDIAccess::sendMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStampInMilliseconds)
+{
+    if (m_hasAccess && portIndex < m_outputs.size() && data && length > 1) {
+        // Filter out System Exclusive messages if we're not allowed.
+        // FIXME: implement more extensive filtering.
+        if (data[0] >= 0xf0 && !m_midiOptions.sysex)

[Takashi Toyoshima, 2013/07/09 10:19:11]

It should raise SecurityError if it detects forbidden sysex access.

Also this is just a comment for the future work.
It may be better to have this check in MIDIOutput class. We'll implement MIDI
protocol parser to complement running statuses in MIDIOutput since it depends on
MIDI port contexts. So sysex checker can be merged to the parser.

[Chris Rogers, 2013/07/17 21:28:12]

Done.  Now raising SecurityError

Also moved this check into MIDIOutput

+            return;
+
+        // Convert from a time in milliseconds (a DOMHighResTimeStamp) according to the same time coordinate system as performance.now()
+        // into a time in seconds which is based on the time coordinate system of monotonicallyIncreasingTime().
+        double timeStamp;
+
+        if (!timeStampInMilliseconds) {
+            // We treat a value of 0 (which is the default value) as special, meaning "now".
+            // We need to translate it exactly to 0 seconds.
+            timeStamp = 0;
+        } else {
+            Document* document = toDocument(scriptExecutionContext());
+            ASSERT(document);
+            double documentStartTime = document->loader()->timing()->referenceMonotonicTime();
+            timeStamp = documentStartTime + 0.001 * timeStampInMilliseconds;
+        }
+
+        m_accessor->sendMIDIData(portIndex, data, length, timeStamp);
+    }
+}
+
 void MIDIAccess::stop()
 {
     m_hasAccess = false;
+    m_accessor.clear();
 }
 
 } // namespace WebCore