Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: src/heap/heap.cc

Issue 1885723002: disallow left-trim fast path when sampling heap profiler is active (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: explicitly trigger a scavenge in the test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profiler/heap-profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 5c2d5786099bff15cd894eea21f08693bd4dc0cf..c7956a3d5dad46a3efac69cb8b0b432c2576deeb 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -3090,6 +3090,9 @@ void Heap::CreateFillerObjectAt(Address addr, int size,
bool Heap::CanMoveObjectStart(HeapObject* object) {
if (!FLAG_move_object_start) return false;
+ // Sampling heap profiler may have a reference to the object.
+ if (isolate()->heap_profiler()->is_sampling_allocations()) return false;
+
Address address = object->address();
if (lo_space()->Contains(object)) return false;
« no previous file with comments | « no previous file | src/profiler/heap-profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698