src/profiler/heap-profiler.h - Issue 1885723002: disallow left-trim fast path when sampling heap profiler is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/heap-profiler.h

Issue 1885723002: disallow left-trim fast path when sampling heap profiler is active (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: explicitly trigger a scavenge in the test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/profiler/heap-profiler.h

diff --git a/src/profiler/heap-profiler.h b/src/profiler/heap-profiler.h

index 74539ae142786557bc3229e870b66f076192ed78..32e143c74ff22ddbfce5dadd2823f5122fd64598 100644

--- a/src/profiler/heap-profiler.h

+++ b/src/profiler/heap-profiler.h

@@ -32,6 +32,7 @@ class HeapProfiler {

bool StartSamplingHeapProfiler(uint64_t sample_interval, int stack_depth);

void StopSamplingHeapProfiler();

+ bool is_sampling_allocations() { return !sampling_heap_profiler_.is_empty(); }

AllocationProfile* GetAllocationProfile();

void StartHeapObjectsTracking(bool track_allocations);

« no previous file with comments | « src/heap/heap.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »