Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

Issue 1885703003: Make testharness.js tests fail on uncaught exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Recover script changes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py
index 3d45fb8751b7405c7eb0a287bb51622c4990e8e1..59e36cde83b07c5715c69b22109f995843cd7eb0 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py
@@ -81,7 +81,7 @@ def is_testharness_output_passing(content_text):
return True
-def is_testharness_output_with_console_errors_or_warnings(content_text):
+def is_testharness_output_with_console_errors(content_text):
"""
Returns whether the content_text in parameter is a testharness output with
console errors.
@@ -92,7 +92,24 @@ def is_testharness_output_with_console_errors_or_warnings(content_text):
lines = content_text.strip().splitlines()
for line in lines:
- if line.startswith('CONSOLE ERROR:') or line.startswith('CONSOLE WARNING:'):
+ if line.startswith('CONSOLE ERROR:'):
+ return True
+
+ return False
+
+
+def is_testharness_output_with_console_warnings(content_text):
+ """
+ Returns whether the content_text in parameter is a testharness output with
+ console warnings.
+
+ Note:
+ It is expected that the |content_text| is a testharness output.
+ """
+
+ lines = content_text.strip().splitlines()
+ for line in lines:
+ if line.startswith('CONSOLE WARNING:'):
return True
return False

Powered by Google App Engine
This is Rietveld 408576698