third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py - Issue 1885703003: Make testharness.js tests fail on uncaught exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

Issue 1885703003: Make testharness.js tests fail on uncaught exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Recover script changes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/check-testharness-expected-pass ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

index a474151d4d6024d3f9cc1b4cf20637a40e672e8b..702a30c09d53a1a67ac89ac5fdb9bfd46a28f1b1 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

@@ -300,7 +300,8 @@ class SingleTestRunner(object):

if not testharness_results.is_testharness_output(text):

return False, []

- if not testharness_results.is_testharness_output_passing(text):

+ if (not testharness_results.is_testharness_output_passing(text) or

+ testharness_results.is_testharness_output_with_console_errors(text)):

return True, [test_failures.FailureTestHarnessAssertion()]

return True, []