third_party/WebKit/Tools/Scripts/check-testharness-expected-pass - Issue 1885703003: Make testharness.js tests fail on uncaught exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/check-testharness-expected-pass

Issue 1885703003: Make testharness.js tests fail on uncaught exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Recover script changes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/web-animations-api/player-ready-promise-expected.txt ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/check-testharness-expected-pass

diff --git a/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass b/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass

index 7ed48f7947b700c48e79795abda8e40a1e76d4f6..c41e5399b4add8201188994d2c1c39565772b61d 100755

--- a/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass

+++ b/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass

@@ -23,7 +23,8 @@ for path in sys.argv[1:]:

content = open(path, 'r').read()

if (testharness_results.is_testharness_output(content) and

testharness_results.is_testharness_output_passing(content) and

- not testharness_results.is_testharness_output_with_console_errors_or_warnings(content)):

+ not testharness_results.is_testharness_output_with_console_errors(content) and

+ not testharness_results.is_testharness_output_with_console_warnings(content)):

paths.append(path)

if len(paths) > 0: