Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1885623002: Make more unit tests run on Vulkan (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -32 lines) Patch
M tests/BitmapCopyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipBoundsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CopySurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/FloatingPointTextureTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M tests/ImageNewShaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/SpecialImageTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/Test.h View 1 chunk +3 lines, -0 lines 2 comments Download
M tests/TestTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
bsalomon
These are the unit tests that ran on all GL rendering contexts but pass/don't crash ...
4 years, 8 months ago (2016-04-12 16:42:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885623002/1
4 years, 8 months ago (2016-04-12 16:42:50 UTC) #5
jvanverth1
lgtm + comment https://codereview.chromium.org/1885623002/diff/1/tests/Test.h File tests/Test.h (right): https://codereview.chromium.org/1885623002/diff/1/tests/Test.h#newcode174 tests/Test.h:174: DEF_GPUTEST_FOR_CONTEXTS(name, sk_gpu_test::GrContextFactory::IsRenderingContext, \ Why is this ...
4 years, 8 months ago (2016-04-12 16:49:40 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 16:52:21 UTC) #8
bsalomon
https://codereview.chromium.org/1885623002/diff/1/tests/Test.h File tests/Test.h (right): https://codereview.chromium.org/1885623002/diff/1/tests/Test.h#newcode174 tests/Test.h:174: DEF_GPUTEST_FOR_CONTEXTS(name, sk_gpu_test::GrContextFactory::IsRenderingContext, \ On 2016/04/12 16:49:40, jvanverth1 wrote: > ...
4 years, 8 months ago (2016-04-12 16:58:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885623002/1
4 years, 8 months ago (2016-04-12 16:58:42 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 17:00:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/68d9134bec16e91c4a6cde071bcaa579bc0801a7

Powered by Google App Engine
This is Rietveld 408576698