Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 1881033002: Fix Vk build breakage due to new GrSLType (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add asserts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M src/gpu/vk/GrVkUniformHandler.cpp View 1 5 chunks +21 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
bsalomon
4 years, 8 months ago (2016-04-12 14:32:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881033002/20001
4 years, 8 months ago (2016-04-12 14:34:30 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-12 14:34:31 UTC) #5
egdaniel
lgtm
4 years, 8 months ago (2016-04-12 14:35:42 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:46:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/134af6b6d2639033b32e23cecc651f26466e584c

Powered by Google App Engine
This is Rietveld 408576698