chrome/common/extensions/permissions/usb_device_permission.cc - Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/usb_device_permission.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Even more param reductions Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/permissions/permission_message.h ('K') | « chrome/common/extensions/permissions/socket_permission.cc ('k') | chrome/test/data/extensions/permissions/more-than-3-hosts.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/usb_device_permission.cc

diff --git a/chrome/common/extensions/permissions/usb_device_permission.cc b/chrome/common/extensions/permissions/usb_device_permission.cc

index ef832c149e7f6e1a317d29f76d8dc2ec8b8e041a..37189f6639523c7b47bc2446d3b74b96783717c5 100644

--- a/chrome/common/extensions/permissions/usb_device_permission.cc

+++ b/chrome/common/extensions/permissions/usb_device_permission.cc

@@ -49,19 +49,22 @@ PermissionMessages UsbDevicePermission::GetMessages() const {

l10n_util::GetStringFUTF16(

IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE,

ASCIIToUTF16(product),

- ASCIIToUTF16(vendor))));

+ ASCIIToUTF16(vendor)),

+ string16()));

} else {

result.push_back(PermissionMessage(

PermissionMessage::kUsbDevice,

l10n_util::GetStringFUTF16(

IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_MISSING_PRODUCT,

- ASCIIToUTF16(vendor))));

+ ASCIIToUTF16(vendor)),

+ string16()));

}

} else {

result.push_back(PermissionMessage(

PermissionMessage::kUsbDevice,

l10n_util::GetStringUTF16(

- IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_MISSING_VENDOR)));

+ IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_MISSING_VENDOR),

+ string16()));

}

#else