Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3756)

Unified Diff: chrome/common/extensions/permissions/socket_permission.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Even more param reductions Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/socket_permission.cc
diff --git a/chrome/common/extensions/permissions/socket_permission.cc b/chrome/common/extensions/permissions/socket_permission.cc
index bb1dd3b9088c07cff9747dc02f74de4e4dbe9c24..518d507e472ddc29fdf0042a56311ef147e4ae97 100644
--- a/chrome/common/extensions/permissions/socket_permission.cc
+++ b/chrome/common/extensions/permissions/socket_permission.cc
@@ -41,7 +41,8 @@ bool SocketPermission::AddAnyHostMessage(PermissionMessages& messages)
messages.push_back(PermissionMessage(
PermissionMessage::kSocketAnyHost,
l10n_util::GetStringUTF16(
- IDS_EXTENSION_PROMPT_WARNING_SOCKET_ANY_HOST)));
+ IDS_EXTENSION_PROMPT_WARNING_SOCKET_ANY_HOST),
+ string16()));
return true;
}
}
@@ -66,7 +67,8 @@ void SocketPermission::AddSubdomainHostMessage(PermissionMessages& messages)
id,
JoinString(
std::vector<string16>(
- domains.begin(), domains.end()), ' '))));
+ domains.begin(), domains.end()), ' ')),
+ string16()));
}
}
@@ -88,7 +90,8 @@ void SocketPermission::AddSpecificHostMessage(PermissionMessages& messages)
id,
JoinString(
std::vector<string16>(
- hostnames.begin(), hostnames.end()), ' '))));
+ hostnames.begin(), hostnames.end()), ' ')),
+ string16()));
}
}

Powered by Google App Engine
This is Rietveld 408576698