chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc - Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Polishing Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('j') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

diff --git a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

index ebf2bda17dbb7e7474eb78a7a7d64cd76aafffea..7cfce2dd9a63fe943d6864d5e25270daab0763f0 100644

--- a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

+++ b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

@@ -266,16 +266,16 @@ ExtensionInstallDialog::ExtensionInstallDialog(

permissions_container = left_column_area;

}

- if (prompt.GetPermissionCount() > 0) {

+ if (prompt.GetPermissionCount(false) > 0) {

GtkWidget* permissions_header = gtk_util::CreateBoldLabel(

UTF16ToUTF8(prompt.GetPermissionsHeading()).c_str());

gtk_util::SetLabelWidth(permissions_header, left_column_min_width);

gtk_box_pack_start(GTK_BOX(permissions_container), permissions_header,

FALSE, FALSE, 0);

- for (size_t i = 0; i < prompt.GetPermissionCount(); ++i) {

+ for (size_t i = 0; i < prompt.GetPermissionCount(false); ++i) {

std::string permission = l10n_util::GetStringFUTF8(

- IDS_EXTENSION_PERMISSION_LINE, prompt.GetPermission(i));

+ IDS_EXTENSION_PERMISSION_LINE, prompt.GetPermission(i, false));

GtkWidget* permission_label = gtk_label_new(permission.c_str());

gtk_util::SetLabelWidth(permission_label, left_column_min_width);

gtk_box_pack_start(GTK_BOX(permissions_container), permission_label,