Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <gtk/gtk.h>
 
 #include "base/i18n/rtl.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/bundle_installer.h"
@@ skipping 248 matching lines @@
   if (show_permissions) {
     GtkWidget* permissions_container;
     if (is_inline_install) {
       permissions_container = content_vbox;
       gtk_box_pack_start(GTK_BOX(content_vbox), gtk_hseparator_new(),
                          FALSE, FALSE, ui::kControlSpacing);
     } else {
       permissions_container = left_column_area;
     }
 
-    if (prompt.GetPermissionCount() > 0) {
+    if (prompt.GetPermissionCount(false) > 0) {
       GtkWidget* permissions_header = gtk_util::CreateBoldLabel(
           UTF16ToUTF8(prompt.GetPermissionsHeading()).c_str());
       gtk_util::SetLabelWidth(permissions_header, left_column_min_width);
       gtk_box_pack_start(GTK_BOX(permissions_container), permissions_header,
                          FALSE, FALSE, 0);
 
-      for (size_t i = 0; i < prompt.GetPermissionCount(); ++i) {
+      for (size_t i = 0; i < prompt.GetPermissionCount(false); ++i) {
         std::string permission = l10n_util::GetStringFUTF8(
-            IDS_EXTENSION_PERMISSION_LINE, prompt.GetPermission(i));
+            IDS_EXTENSION_PERMISSION_LINE, prompt.GetPermission(i, false));
         GtkWidget* permission_label = gtk_label_new(permission.c_str());
         gtk_util::SetLabelWidth(permission_label, left_column_min_width);
         gtk_box_pack_start(GTK_BOX(permissions_container), permission_label,
                            FALSE, FALSE, kPermissionsPadding);
       }
     } else {
       GtkWidget* permission_label = gtk_label_new(l10n_util::GetStringUTF8(
           IDS_EXTENSION_NO_SPECIAL_PERMISSIONS).c_str());
       gtk_util::SetLabelWidth(permission_label, left_column_min_width);
       gtk_box_pack_start(GTK_BOX(permissions_container), permission_label,
@@ skipping 153 matching lines @@
   new chrome::ExtensionInstallDialog(show_params, delegate, prompt);
 }
 
 }  // namespace
 
 // static
 ExtensionInstallPrompt::ShowDialogCallback
 ExtensionInstallPrompt::GetDefaultShowDialogCallback() {
   return base::Bind(&ShowExtensionInstallDialogImpl);
 }