Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Polishing Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
index 51e4bee3c2350801213d19908ec9e61c281a9a55..03eeef92cf2019350cebd035571077eaf3bc798e 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
@@ -38,7 +38,7 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsNormalCancel) {
std::vector<string16> permissions;
permissions.push_back(UTF8ToUTF16("warning 1"));
- prompt.SetPermissions(permissions);
+ prompt.SetPermissions(permissions, false);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc] initWithNavigator:browser()
@@ -66,7 +66,7 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsNormalCancel) {
EXPECT_NSEQ([[outlineView dataSource] outlineView:outlineView
objectValueForTableColumn:nil
byItem:[outlineView itemAtRow:1]],
- base::SysUTF16ToNSString(prompt.GetPermission(0)));
+ base::SysUTF16ToNSString(prompt.GetPermission(0, false)));
EXPECT_TRUE([controller cancelButton]);
EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
@@ -90,7 +90,7 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsNormalOK) {
chrome::BuildExtensionInstallPrompt(extension_.get());
std::vector<string16> permissions;
permissions.push_back(UTF8ToUTF16("warning 1"));
- prompt.SetPermissions(permissions);
+ prompt.SetPermissions(permissions, false);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc] initWithNavigator:browser()
@@ -114,12 +114,12 @@ TEST_F(ExtensionInstallViewControllerTest, MultipleWarnings) {
chrome::BuildExtensionInstallPrompt(extension_.get());
std::vector<string16> permissions;
permissions.push_back(UTF8ToUTF16("warning 1"));
- one_warning_prompt.SetPermissions(permissions);
+ one_warning_prompt.SetPermissions(permissions, false);
ExtensionInstallPrompt::Prompt two_warnings_prompt =
chrome::BuildExtensionInstallPrompt(extension_.get());
permissions.push_back(UTF8ToUTF16("warning 2"));
- two_warnings_prompt.SetPermissions(permissions);
+ two_warnings_prompt.SetPermissions(permissions, false);
base::scoped_nsobject<ExtensionInstallViewController> controller1(
[[ExtensionInstallViewController alloc]
@@ -254,7 +254,7 @@ TEST_F(ExtensionInstallViewControllerTest, OAuthIssues) {
chrome::BuildExtensionInstallPrompt(extension_.get());
std::vector<string16> permissions;
permissions.push_back(UTF8ToUTF16("warning 1"));
- prompt.SetPermissions(permissions);
+ prompt.SetPermissions(permissions, false);
IssueAdviceInfoEntry issue;
issue.description = UTF8ToUTF16("issue description 1");
issue.details.push_back(UTF8ToUTF16("issue detail 1"));
@@ -284,7 +284,7 @@ TEST_F(ExtensionInstallViewControllerTest, PostInstallPermissionsPrompt) {
chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get());
std::vector<string16> permissions;
permissions.push_back(UTF8ToUTF16("warning 1"));
- prompt.SetPermissions(permissions);
+ prompt.SetPermissions(permissions, false);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc] initWithNavigator:browser()

Powered by Google App Engine
This is Rietveld 408576698